fix: correct linking when setting defaultVersionShown to non-latest v…

…ersion
facebook · Aug 9, 2018 · 509646d · 509646d
1 parent e27e18b
commit 509646d
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 2 deletions.
diff --git a/lib/server/__tests__/docs.test.js b/lib/server/__tests__/docs.test.js
@@ -34,6 +34,7 @@ jest.mock('../env', () => ({
   versioning: {
     enabled: true,
     defaultVersion: '1.0.0',
+    latestVersion: '1.0.0',
   },
 }));
 

diff --git a/lib/server/docs.js b/lib/server/docs.js
@@ -57,7 +57,7 @@ function mdToHtmlify(oldContent, mdToHtml, metadata) {
       htmlLink = htmlLink.replace('/en/', `/${metadata.language}/`);
       htmlLink = htmlLink.replace(
         '/VERSION/',
-        metadata.version && metadata.version !== env.versioning.defaultVersion
+        metadata.version && metadata.version !== env.versioning.latestVersion
           ? `/${metadata.version}/`
           : '/'
       );

diff --git a/lib/server/env.js b/lib/server/env.js
@@ -45,6 +45,7 @@ class Translation {
 class Versioning {
   constructor() {
     this.enabled = false;
+    this.latestVersion = null;
     this.defaultVersion = null;
     this.versions = [];
     this.missingVersionsPage = false;
@@ -64,9 +65,10 @@ class Versioning {
     if (fs.existsSync(versionsJSONFile)) {
       this.enabled = true;
       this.versions = JSON.parse(fs.readFileSync(versionsJSONFile, 'utf8'));
+      this.latestVersion = this.versions[0];
       this.defaultVersion = siteConfig.defaultVersionShown
         ? siteConfig.defaultVersionShown
-        : this.versions[0]; // otherwise show the latest version (other than next/master)
+        : this.latestVersion; // otherwise show the latest version (other than next/master)
     }
 
     if (!fs.existsSync(versionsFile)) {