patch PR #1440 (#1441)

* alternative implementation * typo * refactor noop * rename SearchAlgolia -> SearchBar * changes.md
facebook · May 8, 2019 · fdf1054 · fdf1054
1 parent 87c746a
commit fdf1054
Show file tree

Hide file tree

Showing 8 changed files with 12 additions and 19 deletions.
diff --git a/packages/docusaurus-preset-classic/src/index.js b/packages/docusaurus-preset-classic/src/index.js
@@ -9,10 +9,10 @@ module.exports = function preset(context, opts = {}) {
   return {
     themes: [
       {
-        name: '@docusaurus/theme-search-algolia',
+        name: '@docusaurus/theme-classic',
       },
       {
-        name: '@docusaurus/theme-classic',
+        name: '@docusaurus/theme-search-algolia',
       },
     ],
     plugins: [

diff --git a/packages/docusaurus-theme-classic/src/index.js b/packages/docusaurus-theme-classic/src/index.js
@@ -22,16 +22,6 @@ class DocusaurusThemeClassic {
   getThemePath() {
     return path.resolve(__dirname, './theme');
   }
-
-  configureWebpack() {
-    return {
-      resolve: {
-        alias: {
-          '@theme/SearchAlgolia': path.resolve(__dirname, './noopModule.js'),
-        },
-      },
-    };
-  }
 }
 
 module.exports = DocusaurusThemeClassic;
diff --git a/packages/docusaurus-theme-classic/src/theme/Navbar/index.js b/packages/docusaurus-theme-classic/src/theme/Navbar/index.js
@@ -10,7 +10,7 @@ import React from 'react';
 import Link from '@docusaurus/Link';
 import useDocusaurusContext from '@docusaurus/useDocusaurusContext';
 
-import SearchAlgolia from '@theme/SearchAlgolia';
+import SearchBar from '@theme/SearchBar';
 
 function Navbar() {
   const context = useDocusaurusContext();
@@ -75,7 +75,7 @@ function Navbar() {
         <div className="navbar__items navbar__items--right">
           {algolia && (
             <div className="navbar__search" key="search-box">
-              <SearchAlgolia />
+              <SearchBar />
             </div>
           )}
         </div>

diff --git a/packages/docusaurus-theme-classic/src/theme/SearchBar.js b/packages/docusaurus-theme-classic/src/theme/SearchBar.js
@@ -0,0 +1,8 @@
+/**
+ * Copyright (c) 2017-present, Facebook, Inc.
+ *
+ * This source code is licensed under the MIT license found in the
+ * LICENSE file in the root directory of this source tree.
+ */
+
+export {default} from '@docusaurus/Noop';
diff --git a/...-algolia/src/theme/SearchAlgolia/index.js → ...arch-algolia/src/theme/SearchBar/index.js b/...-algolia/src/theme/SearchAlgolia/index.js → ...arch-algolia/src/theme/SearchBar/index.js
@@ -21,7 +21,6 @@ class Search extends React.Component {
 
   componentDidMount() {
     const {siteConfig = {}, metadata = {}} = this.context;
-    console.log(siteConfig);
     const {version: thisVersion, language: thisLanguage} = metadata;
     const {
       themeConfig: {algolia},

diff --git a/...lgolia/src/theme/SearchAlgolia/styles.css → ...ch-algolia/src/theme/SearchBar/styles.css b/...lgolia/src/theme/SearchAlgolia/styles.css → ...ch-algolia/src/theme/SearchBar/styles.css
diff --git a/packages/docusaurus/CHANGES.md b/packages/docusaurus/CHANGES.md
@@ -15,10 +15,6 @@ headerLinks: [
   { url: "help", label: "Help" },
   // Links to href destination/ external page
   { href: "https://github.com/", label: "GitHub" },
-  // Determines search bar position among links
-  { search: true },
-  // Determines language drop down position among links
-  { languages: true }
 ],
 ```
 

diff --git a/...ocusaurus-theme-classic/src/noopModule.js → ...ges/docusaurus/lib/client/exports/Noop.js b/...ocusaurus-theme-classic/src/noopModule.js → ...ges/docusaurus/lib/client/exports/Noop.js