Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposal: upgrade Remark to v13.0.0 #3668

Closed
TheodoreChu opened this issue Oct 31, 2020 · 8 comments
Closed

Proposal: upgrade Remark to v13.0.0 #3668

TheodoreChu opened this issue Oct 31, 2020 · 8 comments
Labels
proposal This issue is a proposal, usually non-trivial change

Comments

@TheodoreChu
Copy link
Contributor

💥 Proposal: upgrade Remark to v13.0.0

It looks like the mdx-loader is using Remark v12.0.0: https://github.com/facebook/docusaurus/blob/master/packages/docusaurus-mdx-loader/package.json#L39

Remark v13.0.0 was released in mid-October. The release notes explain that "It replaces the 5+ year old internals with a new low-level parser: micromark.": https://github.com/remarkjs/remark/releases/tag/13.0.0

Reasons to upgrade:

  • The latest versions of many remark plugins do not work with versions of Remark less than v13.0.0

Concerns:

Have you read the Contributing Guidelines on issues?

Yes

@TheodoreChu TheodoreChu added status: needs triage This issue has not been triaged by maintainers proposal This issue is a proposal, usually non-trivial change labels Oct 31, 2020
@slorber slorber removed the status: needs triage This issue has not been triaged by maintainers label Nov 2, 2020
@slorber
Copy link
Collaborator

slorber commented Nov 2, 2020

Thanks, we'll look into upgrading to Remark 13 but probably a bit later

@lex111
Copy link
Contributor

lex111 commented Nov 10, 2020

It looks like the mdx-loader is using Remark v12.0.0:

Not exactly true, we are using Remark 12 to execute tests. To render MD content, we use @mdx-js/mdx, which in turn uses Remark 12. But as far as I understand, it's quite difficult to migrate to the new remark in mdx-js. Therefore, this upgrade does not depend on us at this time.

@TheodoreChu
Copy link
Contributor Author

Great, thanks for the clarification @lex111.

@wooorm
Copy link
Contributor

wooorm commented Nov 21, 2020

We spoke a while back about separating markdown from mdx, e.g., .md is markdown, .mdx is MDX. If that’s implemented, then it should be possible to upgrade to remark@13 for the markdown part, leaving MDX to using remark@12 (or, what’s it on? I think MDX is on an older version) for now?

@alexkreidler
Copy link

See also mdx-js/mdx#1367, recently merged, for progress on integrating Remark 13 into MDX (@mdx-js/mdx).

@lunelson
Copy link

I stated this in the other issues but FWIW xdm is always in sync with the latest remark, and for that matter every other package in the unified ecosystem 🙄

@slorber
Copy link
Collaborator

slorber commented Sep 21, 2021

@wooorm said recently that he's backporting xdm in mdx so we should be able to keep using mdx too

@Josh-Cena
Copy link
Collaborator

Going to close this in favor of #4029. I originally kept this open because I planned to parse Markdown on the server with Remark (see #6261), but due to performance and ROI reasons, I eventually decided that regex is still the best solution. Therefore, the only blocking issue is migration to MDX v2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
proposal This issue is a proposal, usually non-trivial change
Projects
None yet
Development

No branches or pull requests

7 participants