Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: use Remark to parse Markdown on server-side #6261

Closed
wants to merge 3 commits into from

Conversation

Josh-Cena
Copy link
Collaborator

Motivation

Replaces #5670

Fixes #6260
Fixes #6108
Fixes #5659

Have you read the Contributing Guidelines on pull requests?

Yes

Test Plan

TODO

@Josh-Cena Josh-Cena added the pr: bug fix This PR fixes a bug in a past release. label Jan 4, 2022
@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Jan 4, 2022
@netlify
Copy link

netlify bot commented Jan 4, 2022

✔️ [V2]

🔨 Explore the source changes: ae9de69

🔍 Inspect the deploy log: https://app.netlify.com/sites/docusaurus-2/deploys/61f3a2418a9eda000858c5af

😎 Browse the preview: https://deploy-preview-6261--docusaurus-2.netlify.app

@github-actions
Copy link

github-actions bot commented Jan 4, 2022

⚡️ Lighthouse report for the changes in this PR:

Category Score
🟠 Performance 71
🟢 Accessibility 98
🟢 Best practices 100
🟢 SEO 100
🟢 PWA 95

Lighthouse ran on https://deploy-preview-6261--docusaurus-2.netlify.app/

@github-actions
Copy link

github-actions bot commented Jan 4, 2022

Size Change: 0 B

Total Size: 755 kB

ℹ️ View Unchanged
Filename Size
website/.docusaurus/globalData.json 47 kB
website/build/assets/css/styles.********.css 105 kB
website/build/assets/js/main.********.js 573 kB
website/build/index.html 30.1 kB

compressed-size-action

@Josh-Cena
Copy link
Collaborator Author

Josh-Cena commented Jan 4, 2022

There is a performance degradation. On CHANGELOG.md, our previous early-bail-out algorithm runs for 2.9ms; the current one runs for 450ms. We certainly need to find a lazy-evaluated parser. Note however that on smaller files the time is still negligible (some 10ms–40ms) and our CHANGELOG.md isn't really current parsed server-side anyways

@Josh-Cena Josh-Cena marked this pull request as draft January 4, 2022 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA pr: bug fix This PR fixes a bug in a past release.
Projects
None yet
2 participants