-
-
Notifications
You must be signed in to change notification settings - Fork 8.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: use Remark to parse Markdown on server-side #6261
Conversation
✔️ [V2] 🔨 Explore the source changes: ae9de69 🔍 Inspect the deploy log: https://app.netlify.com/sites/docusaurus-2/deploys/61f3a2418a9eda000858c5af 😎 Browse the preview: https://deploy-preview-6261--docusaurus-2.netlify.app |
⚡️ Lighthouse report for the changes in this PR:
Lighthouse ran on https://deploy-preview-6261--docusaurus-2.netlify.app/ |
Size Change: 0 B Total Size: 755 kB ℹ️ View Unchanged
|
There is a performance degradation. On CHANGELOG.md, our previous early-bail-out algorithm runs for 2.9ms; the current one runs for 450ms. We certainly need to find a lazy-evaluated parser. Note however that on smaller files the time is still negligible (some 10ms–40ms) and our CHANGELOG.md isn't really current parsed server-side anyways |
Motivation
Replaces #5670
Fixes #6260
Fixes #6108
Fixes #5659
Have you read the Contributing Guidelines on pull requests?
Yes
Test Plan
TODO