Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minimal support for IE11 #585

Closed
zenflow opened this issue Apr 18, 2018 · 13 comments
Closed

Minimal support for IE11 #585

zenflow opened this issue Apr 18, 2018 · 13 comments
Labels
bug An error in the Docusaurus core causing instability or issues with its execution difficulty: intermediate Issues that are medium difficulty level, e.g. moderate refactoring with a clear test plan. status: claimed Issue has been claimed by a contributor who plans to work on it.

Comments

@zenflow
Copy link
Contributor

zenflow commented Apr 18, 2018

Is this a bug report?

It's a browser compatibility issue, so Yes?

I couldn't find any documentation on supported browsers. I assume that the modern major browsers are all supported but what about Internet Explorer which is still a major browser? I hope we can have minimal support for it, since our library targets the latest version of all major browsers and our users would expect our docs/examples site to have the same browser support.

Have you read the Contributing Guidelines on issues?

Yes I have

Environment

irrelevant, it's a problem in the built site running in IE11, doesn't matter where the site is built

Steps to Reproduce

  1. Visit https://docusaurus.io/ in the latest version of IE

Expected Behavior

I would expect that maybe not everything looks quite right, but the site is functional / usable.

Actual Behavior

It's impossible to navigate the site because the menu items in the menu bar are all smooshed together in the top right corner and it's impossible to read them or click a particular one.

Reproducible Demo

Visit https://docusaurus.io/ in IE11..
image

@yangshun
Copy link
Contributor

yangshun commented May 4, 2018

@zenflow Would you be able to fix it? Unfortunately we only have Macs :/

@ahmadalfy
Copy link
Contributor

@yangshun I would love to claim and fix this.

@yangshun
Copy link
Contributor

yangshun commented May 6, 2018

@ahmadalfy That's great! Go ahead. Feel free to rewrite the CSS for the nav bar as well 😄

@yangshun yangshun added bug An error in the Docusaurus core causing instability or issues with its execution difficulty: intermediate Issues that are medium difficulty level, e.g. moderate refactoring with a clear test plan. status: claimed Issue has been claimed by a contributor who plans to work on it. labels May 6, 2018
@ahmadalfy
Copy link
Contributor

@yangshun OK this was far more simple than I thought 💃

I found other issues as well that I can fix and they will require minimal changes. I can think of opening a PR with the label [WIP] and every commit fix something then you merge whenever you think it's right. What do you think?

@yangshun
Copy link
Contributor

yangshun commented May 6, 2018

@ahmadalfy Amazing speed! Sounds good. Let's do that 👍

@yangshun
Copy link
Contributor

yangshun commented May 6, 2018

@ahmadalfy If possible, could you list down the IE11 issues you intend to fix as a comment here? We can then use this issue to track the fixes.

@ahmadalfy
Copy link
Contributor

ahmadalfy commented May 6, 2018

@yangshun these are the issues that I found:

  • Navigation collapse
  • Shorthand font format with -apple-system making the value invalid to IE11 and hence ignoring the whole declaration
  • flex-basis and padding with box-sizing: border-box doesn't work as expected and hence causing overflow of the content (one block per line, screenshot 1, screenshot2)
  • Showcase page having the footer on top overlapping everything on the page (screenshot)
  • Massive white space between content and footer (on installation page , screenshot )

@yangshun
Copy link
Contributor

yangshun commented May 6, 2018

Oh gosh. Would love to see your fixes if you are up for it! 🥇

@ahmadalfy
Copy link
Contributor

I am working on it.

@JoelMarcey
Copy link
Contributor

@ahmadalfy Thank you for fixing these! ❤️

@ahmadalfy
Copy link
Contributor

@JoelMarcey you're welcome! Thanks for the motivation you gave me at F8 ❤️

@ahmadalfy
Copy link
Contributor

ahmadalfy commented May 6, 2018

@yangshun the last issue (on installation page) is due to the image in the content. This is a really weird bug I don't think I have ever encountered it before. The image has max-width: 100% and it's width is reduced but someway its original height is occupying the space. I am not sure how 😭

Will investigate.

@endiliey
Copy link
Contributor

We had a css revamp on 1.3.0 #757

I tried this today (we are on 1.3.2) on IE11, the experience is not that bad. Seems quite functional to me

ie11

@endiliey endiliey closed this as completed Aug 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug An error in the Docusaurus core causing instability or issues with its execution difficulty: intermediate Issues that are medium difficulty level, e.g. moderate refactoring with a clear test plan. status: claimed Issue has been claimed by a contributor who plans to work on it.
Projects
None yet
Development

No branches or pull requests

5 participants