Fix font rendering on IE11 #642
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is an issue on IE11, it cannot pick the correct system font because the font `-apple-system` makes the value invalid and hence making the whole declaration invalid. A good solution is to split the shorthand version into separate properties/values and it will work.
|
Deploy preview for docusaurus-preview ready! Built with commit 4817e7d |
|
Screenshot from the deployed version on netlify using IE11
|
|
Cool! I learnt something new today. Thanks for the fix! |
yangshun
approved these changes
May 6, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an issue on IE11, it cannot pick the correct system font because the font
-apple-systemmakes the value invalid and hence making the whole declaration invalid.A good solution is to split the shorthand version into separate properties/values and it will work.
Motivation
Part of fixing issues on IE11 #585
Have you read the Contributing Guidelines on pull requests?
Yes
Test Plan
This is a UI issue, testing on IE11 and other browsers will be sufficient to prove it is working