-
-
Notifications
You must be signed in to change notification settings - Fork 8.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[npm2yarn]: npm init
=> yarn create
#5861
Comments
We are aware of this: #5635 (comment) However, we use a 3rd party dep under the hood which is currently unmaintained. I'm discussing with others about what's the best option. I would prefer forking |
npm init
vs yarn create
npm init
=> yarn create
Just realized this package was developed in the first place to be used by our plugin🤷♂️ #2428 In the future we should discourage this and make everything live on our own repo / our org. Saves a lot of trouble of maintenance |
agree 👍 |
Re: unmaintained 3rd-party dep (nebrelbug/npm-to-yarn): how can this conversation be moved toward a resolution? A) Move Sounds like maybe (A) and (B) have both already been rejected as solutions? If so, does anyone have strong feelings about exactly how (C) looks? |
for time being i created fork, with all know issues for this library |
We have discussed this ourselves and indeed (A) and (B) are not in the interest of FB (I personally like (A) the most). @slorber said he would do the forking himself, but since @armano2 offered to take this over, I do think we would take that courtesy. I would see if Sebastien is happy with that, but he'll be occupied with #5830 at the moment. We already have a lot of forked dependencies owned by Sebastien, so there are precedents. |
i don't mind passing ownership, moving it to him... i just care about fixing issues 😸 |
Thanks 👍 Will maintain the fork under my own name (easier to transfer later to a potential docusaurus-core org that I'm asking for) and publish under |
Have you read the Contributing Guidelines on issues?
Prerequisites
npm run clear
oryarn clear
command.rm -rf node_modules yarn.lock package-lock.json
and re-installing packages.Description
See demo here: https://du0ui.sse.codesandbox.io/docs/intro
If you use
@docusaurus/remark-plugin-npm2yarn
and your code snippet is set like this:I would expect that it would transform the yarn version to
yarn create wdio ./foo
.Steps to reproduce
@docusaurus/remark-plugin-npm2yarn
pluginExpected behavior
I would expect that it would transform the yarn version to
yarn create wdio ./foo
.Actual behavior
It displays
npm init wdio ./foo
andyarn init wdio ./foo
which results in the attempt of creating a new yarn package rather than running thecreate-wdio
starter package.Your environment
Reproducible demo
https://codesandbox.io/s/nice-fire-du0ui?file=/docusaurus.config.js
Self-service
The text was updated successfully, but these errors were encountered: