Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Footer no longer sticks to bottom of page in 2.0.0-beta.22 #7746

Closed
7 tasks done
LichLord91 opened this issue Jul 8, 2022 · 3 comments · Fixed by #7752
Closed
7 tasks done

Footer no longer sticks to bottom of page in 2.0.0-beta.22 #7746

LichLord91 opened this issue Jul 8, 2022 · 3 comments · Fixed by #7752
Labels
bug An error in the Docusaurus core causing instability or issues with its execution

Comments

@LichLord91
Copy link
Contributor

LichLord91 commented Jul 8, 2022

Have you read the Contributing Guidelines on issues?

Prerequisites

  • I'm using the latest version of Docusaurus.
  • I have tried the npm run clear or yarn clear command.
  • I have tried rm -rf node_modules yarn.lock package-lock.json and re-installing packages.
  • I have tried creating a repro with https://new.docusaurus.io.
  • I have read the console error message carefully (if applicable).

Description

It seems that the latest 2.0.0-beta.22 changed the footer behavior to no longer stick to the bottom of the screen as it did in previous iterations. Going through the changelogs I did not see anything that would indicate this behavior change (ofc I could have missed this)

This issue becomes more apparent with a shorter footer and short pages , however if you maximize some of the larger pages it'll happen too.

Examples in beta.22

My site:
https://62c8a564ff781b0008fdb9ec--lichdocs.netlify.app/test3/
image

https://docusaurus.io/docs/playground
Docusaurus Site:
image

Example in beta.21

my site: https://62c78fd7a6bde2000abc5216--lichdocs.netlify.app/test3/test-4/
image

https://stackblitz.com/edit/github-rcr1hm?file=package.json
Stackblitz Playground of Docusaurus beta.21

image

Reproducible demo

No response

Steps to reproduce

  1. Go to site with beta.22 installed
  2. Either go to a small page and see that the footer bar does not stick to the bottom or scroll out a few longer pages to see the same behavior. (longer pages seem to stick)

Expected behavior

Footer should not be contained with the page contents and stick to the bottom of screen.

Actual behavior

Footer wraps with page content instead of sticking to bottom of screen.

Your environment

  • Public source code: its private but this issue is on the main Docsusaurus Site as well
  • Public site URL: https://docs.lichcraft.games/ (2.0.0-beta.21 version) https://62c8a564ff781b0008fdb9ec--lichdocs.netlify.app/ (2.0.0-beta.22 version)
  • Docusaurus version used: 2.0.0-beta.22
  • Environment name and version (e.g. Chrome 89, Node.js 16.4): Node.js 16.5, Netlify
  • Operating system and version (e.g. Ubuntu 20.04.2 LTS): Ubuntu 20.04 LTS

Self-service

  • I'd be willing to fix this bug myself.
@LichLord91 LichLord91 added bug An error in the Docusaurus core causing instability or issues with its execution status: needs triage This issue has not been triaged by maintainers labels Jul 8, 2022
@LichLord91
Copy link
Contributor Author

Setting Html and Body to height: 100%; seemed to fix this. Did it in my custom css

html , body {
	height: 100%;
  }

This is set in the Layout/styles.module.css , i noticed that there was updates to Layout and its css stylesheet in beta.22 . Seems that this style isn't being applied correctly.

image

@Josh-Cena Josh-Cena removed the status: needs triage This issue has not been triaged by maintainers label Jul 9, 2022
@Josh-Cena
Copy link
Collaborator

@LichLord91 Could you try removing the :global on line 1 and 14 locally? If that works you can send a PR.

LichLord91 added a commit to LichLord91/docusaurus that referenced this issue Jul 9, 2022
This fixes html and body tags height from bug report

facebook#7746
@LichLord91
Copy link
Contributor Author

@Josh-Cena that worked... could have sworn I tried that 😓 maybe I didn't save the file before rebuilding haha. Okay pull request sent and CLA signed. Glad I could contribute back albeit the tiniest change ever 🤣 .

Josh-Cena added a commit that referenced this issue Jul 9, 2022
* fix(theme-classic):  fix Layout theme css height

This fixes html and body tags height from bug report

#7746

* Update styles.module.css

Co-authored-by: Joshua Chen <sidachen2003@gmail.com>
slorber pushed a commit that referenced this issue Jul 14, 2022
* fix(theme-classic):  fix Layout theme css height

This fixes html and body tags height from bug report

#7746

* Update styles.module.css

Co-authored-by: Joshua Chen <sidachen2003@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug An error in the Docusaurus core causing instability or issues with its execution
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants