-
-
Notifications
You must be signed in to change notification settings - Fork 8.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Footer no longer sticks to bottom of page in 2.0.0-beta.22 #7746
Labels
bug
An error in the Docusaurus core causing instability or issues with its execution
Comments
LichLord91
added
bug
An error in the Docusaurus core causing instability or issues with its execution
status: needs triage
This issue has not been triaged by maintainers
labels
Jul 8, 2022
Josh-Cena
removed
the
status: needs triage
This issue has not been triaged by maintainers
label
Jul 9, 2022
@LichLord91 Could you try removing the |
LichLord91
added a commit
to LichLord91/docusaurus
that referenced
this issue
Jul 9, 2022
This fixes html and body tags height from bug report facebook#7746
3 tasks
@Josh-Cena that worked... could have sworn I tried that 😓 maybe I didn't save the file before rebuilding haha. Okay pull request sent and CLA signed. Glad I could contribute back albeit the tiniest change ever 🤣 . |
Josh-Cena
added a commit
that referenced
this issue
Jul 9, 2022
* fix(theme-classic): fix Layout theme css height This fixes html and body tags height from bug report #7746 * Update styles.module.css Co-authored-by: Joshua Chen <sidachen2003@gmail.com>
slorber
pushed a commit
that referenced
this issue
Jul 14, 2022
* fix(theme-classic): fix Layout theme css height This fixes html and body tags height from bug report #7746 * Update styles.module.css Co-authored-by: Joshua Chen <sidachen2003@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Have you read the Contributing Guidelines on issues?
Prerequisites
npm run clear
oryarn clear
command.rm -rf node_modules yarn.lock package-lock.json
and re-installing packages.Description
It seems that the latest 2.0.0-beta.22 changed the footer behavior to no longer stick to the bottom of the screen as it did in previous iterations. Going through the changelogs I did not see anything that would indicate this behavior change (ofc I could have missed this)
This issue becomes more apparent with a shorter footer and short pages , however if you maximize some of the larger pages it'll happen too.
Examples in beta.22
My site:
https://62c8a564ff781b0008fdb9ec--lichdocs.netlify.app/test3/
https://docusaurus.io/docs/playground
Docusaurus Site:
Example in beta.21
my site: https://62c78fd7a6bde2000abc5216--lichdocs.netlify.app/test3/test-4/
https://stackblitz.com/edit/github-rcr1hm?file=package.json
Stackblitz Playground of Docusaurus beta.21
Reproducible demo
No response
Steps to reproduce
Expected behavior
Footer should not be contained with the page contents and stick to the bottom of screen.
Actual behavior
Footer wraps with page content instead of sticking to bottom of screen.
Your environment
Self-service
The text was updated successfully, but these errors were encountered: