Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bring back the facebook social button on blog posts #814

Closed
JoelMarcey opened this issue Jun 29, 2018 · 2 comments
Closed

Bring back the facebook social button on blog posts #814

JoelMarcey opened this issue Jun 29, 2018 · 2 comments
Assignees
@endiliey
Labels
feature This is not a bug or issue with Docusausus, per se. It is a feature request for the future. good first issue If you are just getting started with Docusaurus, this issue should be a good place to begin.

Comments

@JoelMarcey
Copy link
Contributor

Is this a bug report?

No. It was just removed.

Have you read the Contributing Guidelines on issues?

Yes

Environment

Docusaurus 1.3.0

Steps to Reproduce

Go to https://docusaurus.io/blog/2018/04/30/How-I-Converted-Profilo-To-Docusaurus

Expected Behavior

The button would be there.

screenshot 2018-06-29 13 39 45

Actual Behavior

No button.

Reproducible Demo

N/A
@JoelMarcey JoelMarcey added feature This is not a bug or issue with Docusausus, per se. It is a feature request for the future. good first issue If you are just getting started with Docusaurus, this issue should be a good place to begin. labels Jun 29, 2018
@JoelMarcey
Copy link
Contributor Author

Not sure if it was removed with this: #673, but that seems like something that could be related.

@endiliey
Copy link
Contributor

It was still there on #673
It was down after #757

It should be

className="fb-like"

According to https://developers.facebook.com/docs/plugins/like-button/

Instead of

className="fbLike"

endiliey added a commit to endiliey/Docusaurus that referenced this issue Jun 30, 2018
@endiliey
fix facebook#814
60dcad8
This was referenced Jun 30, 2018
Merged
Merged
@endiliey endiliey self-assigned this Jul 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@endiliey endiliey

Labels
feature This is not a bug or issue with Docusausus, per se. It is a feature request for the future. good first issue If you are just getting started with Docusaurus, this issue should be a good place to begin.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@JoelMarcey @endiliey