-
-
Notifications
You must be signed in to change notification settings - Fork 8.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make nav
s next to content take up full width
#911
Comments
To sum it up, for example Expected behavior when scrolling at point Current behavior when scrolling at point Is this correct @SimenB ? |
Yup, perfect! |
The left part is fine, but because of the alignment of the right one it's easy to have the cursor too far to the right |
Hi I would like to work on this |
@fiennyangeln it's yours! I've added an "issue: claimed" label so that others will know not to start work on the issue. If you change your mind about the issue, no worries! Just let me know so that I can remove the label and free it up for someone else to claim. I'll check in with you periodically so that we can keep the task updated with the progress. |
@fiennyangeln Excellent! Thank you so much. We've added an Of course, I'll check in with you so that we can keep the task updated with the progress. 😄 |
Ha ha ha @yangshun and I were thinking the same thing 🤣 |
Another thing I noticed that's semi related is that while the left hand navigation gets a scrollbar, the right one does not. Intentional? |
Hmm, do you think its ok if i add another CSS Class to modify the change since i realize most of the css class used by the page like docsNavContainer and mainContainer are used by other page and my change (set flex:1 to the docsNavContainer and onPageNav, remove max-width:1400px and margin:0 auto in the docMainWrapper) will affect other page like Blog ? @JoelMarcey @yangshun |
Hi @fiennyangeln Would adding anything to our |
* Fix nav to take full width in the docs page Fix #911 * Remove using important in css * Make Getting started flushed together with icon
🚀 Feature
Make the left and right hand
nav
s take up the outer width to facilitate easier scrollingMotivation
When scrolling, you have to have the mouse above the ToC to scroll it instead of the page's content. On the right hand, it's easy to have the cursor too far to the right, scrolling the document instead of the content
Pitch
I'm unable to take a screenshot of the pointer, but it's easy to move it too far to the right if the word in the ToC is long enough, e.g.:
If the pointer is a smidge to the right of "modulePathIgnorePatterns [array]" then I scroll the page's content
The text was updated successfully, but these errors were encountered: