-
-
Notifications
You must be signed in to change notification settings - Fork 8.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(theme): simplify CSS solution to solve empty search container #10061
Merged
slorber
merged 2 commits into
main
from
slorber/simplify-empty-search-container-solution
Apr 19, 2024
Merged
refactor(theme): simplify CSS solution to solve empty search container #10061
slorber
merged 2 commits into
main
from
slorber/simplify-empty-search-container-solution
Apr 19, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
slorber
added
the
pr: polish
This PR adds a very minor behavior improvement that users will enjoy.
label
Apr 19, 2024
✅ [V2]
To edit notification comments on pull requests, go to your Netlify site configuration. |
⚡️ Lighthouse report for the deploy preview of this PR
|
Size Change: -50 B (0%) Total Size: 1.59 MB
ℹ️ View Unchanged
|
This was referenced May 24, 2024
This was referenced May 25, 2024
This was referenced May 26, 2024
This was referenced May 27, 2024
This was referenced Aug 27, 2024
This was referenced Sep 4, 2024
This was referenced Sep 8, 2024
This was referenced Sep 11, 2024
This was referenced Sep 28, 2024
This was referenced Oct 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
CLA Signed
Signed Facebook CLA
pr: polish
This PR adds a very minor behavior improvement that users will enjoy.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
In #9385 I used an overkill CSS
:has()
solution that could simply be replaced by:empty
🤦Can't test this in the preview because we use Algolia, but I confirm it works fine locally.