-
-
Notifications
You must be signed in to change notification settings - Fork 8.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: important warning in markdown-features-react.mdx #10236
Conversation
Hi @dpaulos6! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks! |
✅ [V2]Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
⚡️ Lighthouse report for the deploy preview of this PR
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks! |
Thanks for your submission Unfortunately, I'm unlikely to merge this addition because it looks unnecessarily scary, a bit unclear. The underlying problem is deeper than that: when you create And afaik to this day there's no clear solution to "hot swap" the Webpack config of the dev server. So anything affecting the Webpack config will require a restart: So, there are still many cases where you'd rather restart the dev server, and we'll try to improve over time, but for now I'm not sure documenting this way in a single place while so many places can be affected would be a good solution unfortunately. |
I documented the problem more clearly here, to move this out of my head: cc @homotechsual in case you want to understand when this happens better |
Understood, thanks for clarifying it for me! |
Pre-flight checklist
Motivation
When I was registering components to the global scope, as referred in the documentation, @homotechsual helped me out and he told me I might need to restart/rebuild my application after registering the components. Since I didn't find information related to this situation, I added a little warning in case other people encounter the same issue.
Test Plan
I utilized a docusaurus project to preview the changes and used the same warning element that was already in the bottom of the section.
Test links
Deploy preview: https://deploy-preview-10236--docusaurus-2.netlify.app/docs/markdown-features/react/#mdx-component-scope
Related issues/PRs