-
-
Notifications
You must be signed in to change notification settings - Fork 8.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(docs): the _category_.json description attribute should display on generated index pages #10324
fix(docs): the _category_.json description attribute should display on generated index pages #10324
Conversation
generators according to the requirement
Hi @bharateshwq! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks! |
⚡️ Lighthouse report for the deploy preview of this PR
|
✅ [V2]
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM thanks
Did some cleanup but it's working 👍
Motivation
This pull request adds support docs
_category_.json
description
attribute.This
description
attribute will display on the autogenerated index page.Fix #7818
Test Plan
https://deploy-preview-10324--docusaurus-2.netlify.app/tests/docs/category/tests
Thi works for category of autogenerated sidebar slice, using
_category_.json
description:This also works for manually defined sidebar category with a
description