-
-
Notifications
You must be signed in to change notification settings - Fork 8.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(plugin-google-gtag): replace the broken Google Developers links with valid ones #10338
Merged
slorber
merged 2 commits into
facebook:main
from
bohyunjung:fix-broken-google-developers-links
Jul 25, 2024
Merged
docs(plugin-google-gtag): replace the broken Google Developers links with valid ones #10338
slorber
merged 2 commits into
facebook:main
from
bohyunjung:fix-broken-google-developers-links
Jul 25, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bohyunjung
commented
Jul 25, 2024
@@ -69,7 +69,6 @@ export default function pluginGoogleGtag( | |||
href: 'https://www.googletagmanager.com', | |||
}, | |||
}, | |||
// https://developers.google.com/analytics/devguides/collection/gtagjs/#install_the_global_site_tag |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I removed this line because the valid link is already provided in L80.
✅ [V2]Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
⚡️ Lighthouse report for the deploy preview of this PR
|
slorber
added
the
pr: documentation
This PR works on the website or other text documents in the repo.
label
Jul 25, 2024
LGTM thanks 👍 |
This was referenced Aug 30, 2024
Closed
This was referenced Aug 31, 2024
Open
This was referenced Aug 31, 2024
This was referenced Sep 1, 2024
This was referenced Sep 2, 2024
This was referenced Sep 28, 2024
This was referenced Sep 29, 2024
Closed
This was referenced Oct 4, 2024
This was referenced Oct 19, 2024
Open
Open
This was referenced Oct 20, 2024
Merged
This was referenced Nov 10, 2024
This was referenced Nov 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
CLA Signed
Signed Facebook CLA
pr: documentation
This PR works on the website or other text documents in the repo.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pre-flight checklist
Motivation
plugin-google-gtag has a broken link in its documentation:
This PR fixes the links for all versions.
+ Also removing a redundant comment with invalid link from the source. #10338 (comment)
Related issues/PRs
Please refer to #10332 (comment).