fix: reduce number of concurrent git processes spawned #10354
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
⚡️ Lighthouse report for the deploy preview of this PR
|
|
Size Change: -930 B (-0.01%) Total Size: 10.9 MB ℹ️ View Unchanged
|
slorber
requested changes
Jul 30, 2024
Comment on lines
+200
to
+206
| const results = []; | ||
| while (docFiles.length > 0) { | ||
| const batch = docFiles.splice(0, Concurrency); | ||
| const batchResults = await Promise.all(batch.map(processVersionDoc)); | ||
| results.push(...batchResults); | ||
| } | ||
| return results; |
There was a problem hiding this comment.
If Git is the bottleneck, and the env variable name contains Git, then we should limit the concurrent of Git access, and not create chunks of docs processing
The variable name does not match the implementation detail.
Also chunking is not ideal because we can't start new IO work until a full chunk has ended, and we have to wait for the slowest of the 100 docs to have finished processing before starting processing the 100-200 dos chunk.
Using something like https://github.com/sindresorhus/p-queue is better
7 tasks
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pre-flight checklist
Motivation
Replace #10349
Fix #10348
Confirm local fix on https://github.com/zowe/docs-site/ on my M2 Pro
Test Plan
? Wonder how to test this
Test links
Deploy preview: https://deploy-preview-10354--docusaurus-2.netlify.app/