-
-
Notifications
You must be signed in to change notification settings - Fork 8.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(theme): Adjust blog authors line height to show descenders in lowercase letters (g
, j
, p
, q
, and y
)
#10390
fix(theme): Adjust blog authors line height to show descenders in lowercase letters (g
, j
, p
, q
, and y
)
#10390
Conversation
Hi @josh-wong! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks! |
✅ [V2]Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
⚡️ Lighthouse report for the deploy preview of this PR
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks! |
Adjust line height to show lowercase descenders in blog author titles.
46558f6
to
5fab24b
Compare
g
, j
, p
, q
, and y
) in blog author titlesg
, j
, p
, q
, and y
)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch, missed that 😅
LGTM thanks 👍
Pre-flight checklist
Motivation
As mentioned in #10389, this PR fixes an issue with descenders in lowercase letters (
g
,j
,p
,q
, andy
) in author titles being cut off.Important
I tried to find all places where the styles needed to be changed, but please correct me if I missed any places or if the styles need to be adjusted elsewhere or in a different way🙇🏻♂️
Test Plan
Confirmed my changes appear as expected locally.
Note
For problematic screenshots that show the issue, see #10389.
Blog home page
Blog post
Blog authors page
Single blog author page
Test links
Deploy preview: https://deploy-preview-10390--docusaurus-2.netlify.app/
Related issues/PRs
Fix #10389