refactor(core): improve handling of server bundle #10429
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ [V2]
To edit notification comments on pull requests, go to your Netlify site configuration. |
⚡️ Lighthouse report for the deploy preview of this PR
|
|
Size Change: +377 B (0%) Total Size: 11.6 MB ℹ️ View Unchanged
|
slorber
added
the
pr: maintenance
slorber
added
the
Argos
|
The latest updates on your projects. Learn more about Argos notifications ↗︎
|
|
Removed dependencies detected. Learn more about Socket for GitHub ↗︎ 🚮 Removed packages: npm/@argos-ci/playwright@1.9.3, npm/@mdx-js/react@1.0.1, npm/@netlify/functions@1.6.0, npm/@playwright/test@1.46.1, npm/cheerio@1.0.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
While working on this PR, I discovered a few surprising facts so far:
website/build/server/assets/js) and chunks were not removed from production deploymentsChanges I made:
website/build/server/*instead ofwebsite/build/*Test Plan
CI keeps working as before
No perf regression
DOCUSAURUS_KEEP_SERVER_BUNDLE=true yarn build:website:fastworks locally and keeps thewebsite/build/serverfolderBenchmark
So far it doesn't seem to affect performance much, but I'll run this again before merging
Cold cache:
Warm cache:
hyperfine --warmup 1 --runs 5 'yarn build:website:fast' Main Benchmark 1: yarn build:website:fast Time (mean ± σ): 12.584 s ± 0.567 s [User: 19.326 s, System: 3.966 s] Range (min … max): 12.235 s … 13.581 s 5 runs Feat Benchmark 1: yarn build:website:fast Time (mean ± σ): 13.168 s ± 0.723 s [User: 20.047 s, System: 4.027 s] Range (min … max): 12.564 s … 14.162 s 5 runsTest links
https://deploy-preview-10429--docusaurus-2.netlify.app/