feat: add name underneath users logo #1043
Conversation
|
Deploy preview for docusaurus-preview ready! Built with commit 275fdfc |
There was a problem hiding this comment.
@mptap Thank you for the PR. 👍
I think this may require some CSS updates, possibly, given what it looks like in the preview. https://deploy-preview-1043--docusaurus-preview.netlify.com/en/users
|
@JoelMarcey Updated, let me know what you think. |
|
@JoelMarcey Updated |
| @@ -2220,14 +2220,14 @@ input::placeholder { | |||
| } | |||
|
|
|||
| .showcaseSection .logos img { | |||
| max-height: 128px; | |||
| height: 128px; | |||
There was a problem hiding this comment.
This will break logos that aren't square in proportion. For example, have a look at Vuls and ml5.js on https://deploy-preview-1043--docusaurus-preview.netlify.com/en/users and compared them with https://docusaurus.io/en/users. The images are distorted.
You could add a wrapper div that has fixed width and height around all the images so that you can align the names and still maintain the aspect ratio of the images.
There was a problem hiding this comment.
@yangshun Updated, waited for the deploy env to be built - but it is on hold for some reason
| padding: 20px; | ||
| width: 128px; | ||
| } | ||
|
|
||
| @media only screen and (max-width: 735px) { | ||
| .showcaseSection .logos img { | ||
| max-height: 64px; | ||
| height: 64px; |
There was a problem hiding this comment.
@yangshun Updated, waited for the deploy env to be built - but it is on hold for some reason
yangshun
changed the title
endiliey
changed the title
endiliey
changed the title
mptap
force-pushed
the
add_user_name
branch
2 times, most recently
from
3e5ae00
to
6f23219
Compare
| <a href={user.infoLink} key={user.infoLink}> | ||
| <img src={user.image} alt={user.caption} title={user.caption} /> | ||
| </a> | ||
| <div> |
There was a problem hiding this comment.
The key-prop needs to be moved to this div
|
Apologies @mptap we decided to go with another implementation. Thanks for your efforts 😄 |
Motivation
Added name of user underneath logo on users page #1040
Have you read the Contributing Guidelines on pull requests?
Yes
Test Plan
Ran yarn prettier, yarn lint and yarn test