-
-
Notifications
You must be signed in to change notification settings - Fork 8.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(core): faster JS minimizer - siteConfig.future.experimental_faster.swcJsMinimizer
#10441
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ [V2]
To edit notification comments on pull requests, go to your Netlify site configuration. |
⚡️ Lighthouse report for the deploy preview of this PR
|
Size Change: -10 kB (-0.09%) Total Size: 11.6 MB
ℹ️ View Unchanged
|
New and removed dependencies detected. Learn more about Socket for GitHub ↗︎
🚮 Removed packages: npm/@argos-ci/playwright@1.9.3), npm/@mdx-js/react@1.0.1), npm/@netlify/functions@1.6.0), npm/@playwright/test@1.46.1), npm/cheerio@1.0.0) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Docusaurus Faster
This PR is part of the Docusaurus Faster project aiming at reducing production build times
Motivation
Add experimental swcJsMinimizer option to make js minification faster.
It turns out
terser-webpack-plugin
default minimizer is slow and a real bottleneck representing 20-30% of total build time!The plugin offers an option to use a swc-based minimizer instead, which you can now toggle thanks to a new feature flag
siteConfig.future.experimental_faster.swcJsMinimizer
Time to minimize JS on our website:
I'm not sure the options are ideal, but I was conservative and only used a different tool with similar options, instead of fine-tuning the existing options. We
Note: in the future we'll be able to use the built-in Rspack swc minimizer plugin (even faster, no extra JS<->Rust cost)
Test Plan
CI
Test links
https://deploy-preview-10441--docusaurus-2.netlify.app/