Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update support for Web App Manifest #1046

Merged
merged 4 commits into from
Oct 17, 2018
Merged

Update support for Web App Manifest #1046

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
96f7ef5
Add support for Web App Manifest in siteConfig
tirthbodawala Aug 31, 2018
0bf1732
Update api-site-config.md
yangshun Sep 2, 2018
fb8287b
Update api-site-config.md
yangshun Sep 2, 2018
06ca233
Pull changes from latest docusaurus and update the head to reflect pr…
tirthbodawala Oct 17, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions docs/api-site-config.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -203,7 +203,7 @@ Hostname of your server. Useful if you are using GitHub Enterprise.
```

#### `manifest` [string]
Path to your web app manifest (e.g., `/manifest.json`). This will add a `<link>` tag to `<head>` with `rel` as `"manifest"` and `content` as the provided path.
Path to your web app manifest (e.g., `manifest.json`). This will add a `<link>` tag to `<head>` with `rel` as `"manifest"` and `href` as the provided path.

#### `markdownPlugins` [array]
An array of plugins to be loaded by Remarkable, the markdown parser and renderer used by Docusaurus. The plugin will receive a reference to the Remarkable instance, allowing custom parsing and rendering rules to be defined.
Expand Down Expand Up @@ -352,4 +352,4 @@ const siteConfig = {
};

module.exports = siteConfig;
```
```
2 changes: 1 addition & 1 deletion v1/lib/core/Head.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,7 @@ class Head extends React.Component {
<meta httpEquiv="refresh" content={`0; URL=${this.props.redirect}`} />
)}
{this.props.config.manifest && (
<link rel="manifest" content={siteUrl + this.props.config.manifest} />
<link rel="manifest" href={siteUrl + this.props.config.manifest} />
)}
<link
rel="shortcut icon"
Expand Down