Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add Azion as a deployment option #10481

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

VitorAEltz
Copy link

@VitorAEltz VitorAEltz commented Sep 6, 2024

#Pull Request Title: feat-add-azion-deployment

##Description:

This pull request adds documentation for deploying a Docusaurus site to Azion. The new section provides detailed steps for three deployment methods: starting from a template, importing from GitHub, and using the Azion CLI.
Changes:
File: website/docs/deployment.mdx
Summary of Changes:
Added a new section titled "Deploying to Azion".
Included detailed instructions for:
Starting from a template in the Azion Console.
Importing a project from GitHub.
Deploying using the Azion CLI.

Pre-flight checklist

Motivation

Test Plan

Test links

Deploy preview: https://deploy-preview-10481--docusaurus-2.netlify.app/

@facebook-github-bot
Copy link
Contributor

Hi @VitorAEltz!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!

Copy link

netlify bot commented Sep 6, 2024

[V2]

Built without sensitive environment variables

Name Link
🔨 Latest commit edef314
🔍 Latest deploy log https://app.netlify.com/sites/docusaurus-2/deploys/66fe1124a73479000870dc97
😎 Deploy Preview https://deploy-preview-10481--docusaurus-2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

github-actions bot commented Sep 6, 2024

⚡️ Lighthouse report for the deploy preview of this PR

URL Performance Accessibility Best Practices SEO Report
/ 🟠 73 🟢 98 🟢 96 🟢 100 Report
/docs/installation 🟠 54 🟢 97 🟢 100 🟢 100 Report
/docs/category/getting-started 🟠 75 🟢 100 🟢 100 🟠 86 Report
/blog 🟠 60 🟢 96 🟢 100 🟠 86 Report
/blog/preparing-your-site-for-docusaurus-v3 🔴 48 🟢 92 🟢 100 🟢 100 Report
/blog/tags/release 🟠 63 🟢 96 🟢 100 🟠 86 Report
/blog/tags 🟠 73 🟢 100 🟢 100 🟠 86 Report

@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Sep 6, 2024
@Josh-Cena Josh-Cena closed this Sep 6, 2024
@Josh-Cena Josh-Cena reopened this Sep 6, 2024
@Josh-Cena
Copy link
Collaborator

I assumed this is spam but turned out it's not. However, as said in the deployment doc, we don't accept anything bigger than a single paragraph that points to your own deployment documentation.

@VitorAEltz
Copy link
Author

I assumed this is spam but turned out it's not. However, as said in the deployment doc, we don't accept anything bigger than a single paragraph that points to your own deployment documentation.

Perfect Josh, I will make the change, thanks

@Josh-Cena Josh-Cena changed the title feat-add-azion-deployment docs: add Azion as a deployment option Sep 28, 2024
@Josh-Cena
Copy link
Collaborator

@slorber Just so we are on the same page: are we still open to such promotional contributions? I would personally vote no but we haven't historically rejected anyone.

@slorber
Copy link
Collaborator

slorber commented Oct 3, 2024

@slorber Just so we are on the same page: are we still open to such promotional contributions? I would personally vote no but we haven't historically rejected anyone.

I would also vote no.

I postponed my review of this PR because I also think we can't continue growing our deployment page this way, nor want to arbitrate if a provider deserves to be added to the page.

The goal of this page is not to list every possible deployment option and even less to provide marketing and easy-to-obtain backlinks to said services.

I was thinking that in the future we could limit this page to just a few handpicked deployment platforms that we know and are willing to document more extensively (GitHub Pages, Netlify, Vercel), and move everything else to a community-driven resource of other third-party options (it could be as simple as a GitHub discussion)

@Josh-Cena
Copy link
Collaborator

That sounds like a good idea:)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants