refactor(core): rewrite Webpack ChunkAssetPlugin with RuntimeModule #10485
+65
−42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
slorber
added
the
pr: maintenance
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
✅ [V2]
To edit notification comments on pull requests, go to your Netlify site configuration. |
⚡️ Lighthouse report for the deploy preview of this PR
|
|
Size Change: +372 B (0%) Total Size: 11.6 MB ℹ️ View Unchanged
|
|
Hi @hardfist @alexander-akait, can you please let me know if you see any issue with this PR? It's migrating code from |
Closed
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Current code uses Webpack
MainTemplate.hooks.requireExtensionswhich will be removed in Webpack 6 and is not implemented in Rspack (see web-infra-dev/rspack#2982)Since we'd like to use Rspack in the future (#10402) we need to rewrite this to make it compatible with both Webpack 5/6 and Rspack.
As far as I understand, Webpack 5 already implements the deprecated
requireExtensionusing a Runtime module compatibility layer, so I took inspiration from its code to provide the same logic as before:Test Plan
CI + preview to test prefetching still works
https://deploy-preview-10485--docusaurus-2.netlify.app/
Diff of
assets/js/main~runtime.<hash>.jsdoes not show any significant change to the runtime chunk: