-
-
Notifications
You must be signed in to change notification settings - Fork 8.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: new Rsdoctor official plugin #10588
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ [V2]
To edit notification comments on pull requests, go to your Netlify site configuration. |
Size Change: +44.1 kB (+0.4%) Total Size: 11.2 MB
ℹ️ View Unchanged
|
⚡️ Lighthouse report for the deploy preview of this PR
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Rsdoctor helps troubleshoot slow Webpack/Rspack builds.
We use it on our website to optimize Docusaurus, but this could be useful for other site and third-party plugin authors as well, so let's make an official plugin for it.
The impl is able to support both Webpack (default) or Rspack (opt-in, see Docusaurus Faster)
The impl pass through the options to Rsdoctor without validating them. Users should refer to the official Rsdoctor options doc directly through the
rsdoctorOptions
.Usage:
I created a separate nested option object because we might add other Docusaurus prioprietary options later (that are not part of the Rsdoctor plugin options).
Test Plan
CI + dogfood on our own website
Test links
Docs: https://deploy-preview-10588--docusaurus-2.netlify.app/docs/api/plugins/@docusaurus/plugin-rsdoctor