-
-
Notifications
You must be signed in to change notification settings - Fork 8.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(theme): Restore former globalThis.Prism #10618
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
slorber
added
pr: bug fix
This PR fixes a bug in a past release.
Argos
Add this label to run UI visual regression tests. See argos.yml GH action.
labels
Oct 25, 2024
✅ [V2]
To edit notification comments on pull requests, go to your Netlify site configuration. |
Size Change: +390 B (0%) Total Size: 11.1 MB
ℹ️ View Unchanged
|
⚡️ Lighthouse report for the deploy preview of this PR
|
The latest updates on your projects. Learn more about Argos notifications ↗︎
|
Size Change: +380 B (0%) Total Size: 11.6 MB
ℹ️ View Unchanged
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Argos
Add this label to run UI visual regression tests. See argos.yml GH action.
CLA Signed
Signed Facebook CLA
pr: bug fix
This PR fixes a bug in a past release.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
While trying to upgrade Redocusaurus to Docusaurus Faster (rohit-gohri/redocusaurus#385) I have weird SSG errors after trying to build with swc instead of babel-loader.
Redoc also uses Prism and those errors go away if we restore the Prism global namespace pollution after the prism-react-renderer init. This code should rather keep the pollution in place if something else is working with Prism.
Test Plan
Not sure how to test this 😅
https://deploy-preview-10618--docusaurus-2.netlify.app/
For context, those SSG errors were: