fix(faster): Upgrade to Rspack 1.1.1, fix build progress bar display #10648
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ [V2]
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
Size Change: +417 B (0%) Total Size: 11.2 MB
ℹ️ View Unchanged
|
⚡️ Lighthouse report for the deploy preview of this PR
|
|
Size Change: +327 B (0%) Total Size: 11.7 MB ℹ️ View Unchanged
|
seems a bug of rspack, will fix it ASAP |
2 tasks
|
Could you also change the Current: Suggest: |
7 tasks
@slorber this progressChars seems set by docusaurus here, so may need to change docusaurus setting |
|
Yes I'll update it 👍 |
slorber
changed the title
|
Looks like 1.1.1 is working fine: https://github.com/web-infra-dev/rspack/releases/tag/v1.1.1 |
2 tasks
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
The new version of Rspack fixes a little visual glitch in the Docusaurus progress bar when building for production.
There's still an issue when compiling the service worker though (see web-infra-dev/rspack#8301 (comment)) but it's a nice DX improvement already.
This is a draft because there are dev server hot reload issues that I need to solve:
Test Plan
CI + local dev test
Test links
https://deploy-preview-10648--docusaurus-2.netlify.app/