Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update Cloudflare Pages deployment link #10901

Merged
merged 2 commits into from
Feb 6, 2025

Conversation

kakakakakku
Copy link
Contributor

@kakakakakku kakakakakku commented Feb 4, 2025

Pre-flight checklist

  • I have read the Contributing Guidelines on pull requests.
  • If this is a code change: I have written unit tests and/or added dogfooding pages to fully verify the new behavior.
  • If this is a new API or substantial change: the PR has an accompanying issue (closes #0000) and the maintainers have approved on my working plan.

Motivation

The Deployment guide currently links to a dev.to blog post for deploying to Cloudflare Pages. However, there is now an official Cloudflare Pages documentation specifically for deploying Docusaurus. I was able to set up my deployment by following this official documentation😀 Therefore, I have updated the link to point to the official documentation instead. Is this change appropriate?

Test Plan

Test links

👇️updated and works good :)
Deploy preview: https://deploy-preview-10901--docusaurus-2.netlify.app/docs/deployment/#deploying-to-cloudflare-pages

Related issues/PRs

N/A

Thank you!

@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Feb 4, 2025
Copy link

netlify bot commented Feb 4, 2025

[V2]

Built without sensitive environment variables

Name Link
🔨 Latest commit 35d2493
🔍 Latest deploy log https://app.netlify.com/sites/docusaurus-2/deploys/67a2a1cceb7d21000887df21
😎 Deploy Preview https://deploy-preview-10901--docusaurus-2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

github-actions bot commented Feb 4, 2025

⚡️ Lighthouse report for the deploy preview of this PR

URL Performance Accessibility Best Practices SEO Report
/ 🔴 45 🟢 98 🟢 96 🟢 100 Report
/docs/installation 🔴 49 🟢 97 🟢 100 🟢 100 Report
/docs/category/getting-started 🟠 72 🟢 100 🟢 100 🟠 86 Report
/blog 🟠 57 🟢 96 🟢 100 🟠 86 Report
/blog/preparing-your-site-for-docusaurus-v3 🟠 74 🟢 92 🟢 100 🟢 100 Report
/blog/tags/release 🟠 62 🟢 96 🟢 100 🟠 86 Report
/blog/tags 🟠 72 🟢 100 🟢 100 🟠 86 Report

@slorber slorber added the pr: internal This PR does not touch production code, or is not meaningful enough to be in the changelog. label Feb 6, 2025
Copy link
Collaborator

@slorber slorber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 👍

Yes this change is appropriate, I prefer to link to the official docs if it exists :)

Copy link
Collaborator

@slorber slorber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 👍

Yes this change is appropriate, I prefer to link to the official docs if it exists :)

@slorber slorber merged commit 801bc7f into facebook:main Feb 6, 2025
11 checks passed
@kakakakakku kakakakakku deleted the update-website-deployment branch February 6, 2025 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA pr: internal This PR does not touch production code, or is not meaningful enough to be in the changelog.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants