Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: use 'sidebar_label' instead of 'title' in prev/next buttons #1122

Merged
merged 2 commits into from
Nov 22, 2018

Conversation

maxaggedon
Copy link
Contributor

Motivation

see #1085

Have you read the Contributing Guidelines on pull requests?

Yes.

Test Plan

capture d ecran 2018-11-21 a 13 35 56

capture d ecran 2018-11-21 a 13 36 29

@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Nov 21, 2018
@docusaurus-bot
Copy link
Contributor

docusaurus-bot commented Nov 21, 2018

Deploy preview for docusaurus-preview ready!

Built with commit fcbf1b3

https://deploy-preview-1122--docusaurus-preview.netlify.com

Copy link
Contributor

@yangshun yangshun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cc @endiliey for a second review since he's more familiar with this part

Copy link
Contributor

@endiliey endiliey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to update the docs as well indicating that sidebar_label will also be used for next/prev button

https://docusaurus.io/docs/en/doc-markdown#documents

@endiliey endiliey merged commit 2df14fe into facebook:master Nov 22, 2018
@maxaggedon maxaggedon deleted the buttons-label-improvement branch November 22, 2018 10:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants