Skip to content

Update @rspack/core dependency to version 1.6.0 #11529

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
Pijukatel wants to merge 1 commit into from
Closed

Update @rspack/core dependency to version 1.6.0 #11529

Pijukatel wants to merge 1 commit into from

Conversation

@Pijukatel
Copy link

@Pijukatel Pijukatel commented Nov 3, 2025

Motivation

Bump @rspack/core to version 1.6.0 to expose incompatibility with the latest version of the package.

@meta-cla
Copy link

meta-cla bot commented Nov 3, 2025

Hi @Pijukatel!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!

@netlify
Copy link

netlify bot commented Nov 3, 2025

✅ [V2]

Built without sensitive environment variables

Name Link
🔨 Latest commit 22b2ce8
🔍 Latest deploy log https://app.netlify.com/projects/docusaurus-2/deploys/69087887b5579f0008d0a408
😎 Deploy Preview https://deploy-preview-11529--docusaurus-2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@Pijukatel Pijukatel closed this Nov 3, 2025
@slorber
Copy link
Collaborator

slorber commented Nov 4, 2025

can you explain the incompatibility problem?

@Pijukatel
Copy link
Author

Pijukatel commented Nov 4, 2025

Hello, I wasn't really sure if it was only our project that experienced it or if it was a problem in general. I tried opening PR here in hopes that it would fail in your CI, but all was green, so probably an issue in our project.

Example error when we tried building our dos with with @rspack/core ==1.6.0 . (Using @rspack/core == 1.5.8 was without problem)

         Error: Can't render static file for pathname "/sdk/python/reference/class/_FetchedPricingInfoDict"
            at generateStaticFile (/home/runner/work/apify-sdk-python/apify-sdk-python/website/node_modules/@docusaurus/core/lib/ssg/ssgRenderer.js:131:20)
            at async /home/runner/work/apify-sdk-python/apify-sdk-python/website/node_modules/p-map/index.js:57:22 {
          [cause]: TypeError: Cannot assign to read only property 'length' of function 'function ApiPage(_ref) {
              var options = _ref.options, packages = _ref.packages, props = _objectWithoutProper...<omitted>...
          }'
              at server.bundle.js:92390:46
              at Array.forEach (<anonymous>)
              at server.bundle.js:92389:24
              at Array.forEach (<anonymous>)
              at Object.render (server.bundle.js:92370:36)
              at LoadableComponent.render (server.bundle.js:86828:21)
              at renderElement (server.bundle.js:75888:23)
              at retryNode (server.bundle.js:76613:16)
              at renderNodeDestructive (server.bundle.js:76407:7)
              at renderElement (server.bundle.js:76340:11)
        },

@slorber
Copy link
Collaborator

slorber commented Nov 4, 2025

hmmm, hard to be sure what is going on here, we'd need a minimal repro to investigate

@Pijukatel Pijukatel mentioned this pull request Jan 8, 2026
Closed
Copilot AI mentioned this pull request Jan 21, 2026
Merged
B4nan added a commit to apify/apify-sdk-python that referenced this pull request Jan 21, 2026
@B4nan
docs: Remove rspack.core <1.6.0 constraint (#745)
35490cc 
The rspack version was pinned to <1.6.0 due to upstream Docusaurus
compatibility issues. Those issues are now resolved.

## Changes

- Removed `"@rspack/core": "<1.6.0"` override from
`website/package.json`
- Regenerated `package-lock.json` 

rspack version now controlled by Docusaurus dependencies (currently
1.5.8), enabling automatic updates when Docusaurus adopts newer
versions.

<!-- START COPILOT ORIGINAL PROMPT -->



<details>

<summary>Original prompt</summary>

> 
> ----
> 
> *This section details on the original issue you should resolve*
> 
> <issue_title>Remove rspack.core <1.6.0 constraint</issue_title>
> <issue_description>Currently updating rspack to the newly released
version 1.6.0 breaks the docs build and so the version has been pinned
to <1.6.0.
> 
> Delete this constraint once the upstream repos are compatible with
rspack 1.6.0</issue_description>
> 
> <agent_instructions>remove the rspack override in the `website` folder
and regenerate lockfile</agent_instructions>
> 
> ## Comments on the Issue (you are @copilot in this section)
> 
> <comments>
> <comment_new><author>@vdusek</author><body>
> once the upstream issues are resolved, remove this constraint in
client and crawlee as well</body></comment_new>
> <comment_new><author>@janbuchar</author><body>
> @Pijukatel @vdusek is there an upstream issue that you could link here
so that we can easily check if the problem still
exists?</body></comment_new>
> <comment_new><author>@Pijukatel</author><body>
> I failed to identify where the problem is. I guessed that it was
facebook/docusaurus#11529, but their CI passed
with such a bump, so it was probably something else.
> 
> I am planning just to watch the bumps and relax the constraint once
some new passes. Recent one failed for example:
>
https://github.com/apify/apify-sdk-python/pull/722</body></comment_new>
> <comment_new><author>@B4nan</author><body>
> the issue is fixed now, we just need to remove the
constraint</body></comment_new>
> </comments>
> 


</details>



<!-- START COPILOT CODING AGENT SUFFIX -->

- Fixes #659

<!-- START COPILOT CODING AGENT TIPS -->
---

💡 You can make Copilot smarter by setting up custom instructions,
customizing its development environment and configuring Model Context
Protocol (MCP) servers. Learn more [Copilot coding agent
tips](https://gh.io/copilot-coding-agent-tips) in the docs.

---------

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: B4nan <615580+B4nan@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@slorber slorber Awaiting requested review from slorber slorber will be requested when the pull request is marked ready for review slorber is a code owner

@Josh-Cena Josh-Cena Awaiting requested review from Josh-Cena Josh-Cena will be requested when the pull request is marked ready for review Josh-Cena is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Pijukatel @slorber