Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: mention about CNAME option in publishing docs #1227

Merged
merged 2 commits into from
Feb 8, 2019
Merged

Conversation

yangshun
Copy link
Contributor

@yangshun yangshun commented Feb 8, 2019

Motivation

Fixes #1226

Have you read the Contributing Guidelines on pull requests?

Yes

Test Plan

See Netlify preview

Related PRs

(If this PR adds or changes functionality, please take some time to update the docs at https://github.com/facebook/docusaurus, and link to your PR here.)

@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Feb 8, 2019
@docusaurus-bot
Copy link
Contributor

docusaurus-bot commented Feb 8, 2019

Deploy preview for docusaurus-preview ready!

Built with commit 2c8a020

https://deploy-preview-1227--docusaurus-preview.netlify.com

@yangshun yangshun merged commit 1efaabc into master Feb 8, 2019
@yangshun yangshun deleted the cname-string branch February 8, 2019 13:16
@JoelMarcey
Copy link
Contributor

Looks good!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants