Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use clean url for og:url when cleanUrl is true #1242

Merged
merged 1 commit into from
Feb 21, 2019
Merged

Use clean url for og:url when cleanUrl is true #1242

merged 1 commit into from
Feb 21, 2019

Conversation

marvinchin
Copy link
Contributor

Motivation

Fix #1233.

Have you read the Contributing Guidelines on pull requests?

Yes.

Test Plan

Set cleanUrl to true in siteConfig.js. Check the og:url meta tag. The value should be the clean url.

@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Feb 21, 2019
@marvinchin
Copy link
Contributor Author

Right now, a trailing slash will be present in the og:url (e.g. https://docusaurus.io/) because of how the getPath method works.

Could I check whether we should keep or remove of the trailing slash?

@docusaurus-bot
Copy link
Contributor

Deploy preview for docusaurus-preview ready!

Built with commit 5115ece

https://deploy-preview-1242--docusaurus-preview.netlify.com

yangshun
yangshun approved these changes Feb 21, 2019
View reviewed changes
Copy link
Contributor

@yangshun yangshun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! We can keep the trailing slash, should be fine.

@yangshun yangshun merged commit b2f3642 into facebook:master Feb 21, 2019
@garethnunns garethnunns mentioned this pull request Mar 18, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yangshun yangshun yangshun approved these changes

Assignees
No one assigned
Labels
CLA Signed Signed Facebook CLA
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@marvinchin @docusaurus-bot @yangshun @facebook-github-bot