Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update api-pages.md to document about overriding default styles #1266

Merged
merged 1 commit into from
Mar 6, 2019

Conversation

ael-mas
Copy link
Contributor

@ael-mas ael-mas commented Mar 6, 2019

Motivation

docs: describe where users can find default styles in api-pages.md documentation file

Have you read the Contributing Guidelines on pull requests?

Yes.

Test Plan

(Write your test plan here. If you changed any code, please provide us with clear instructions on how you verified your changes work. Bonus points for screenshots and videos!)

Related PRs

(If this PR adds or changes functionality, please take some time to update the docs at https://github.com/facebook/docusaurus, and link to your PR here.)

@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Mar 6, 2019
@docusaurus-bot
Copy link
Contributor

Deploy preview for docusaurus-preview ready!

Built with commit b199b3f

https://deploy-preview-1266--docusaurus-preview.netlify.com

Copy link
Contributor

@yangshun yangshun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thank you!

@yangshun yangshun changed the title Update api-pages.md docs: update api-pages.md Mar 6, 2019
@yangshun
Copy link
Contributor

yangshun commented Mar 6, 2019

Thanks for the PR @ael-mas!

Tip: In future do add the issue that this PR fixes/related to in the PR description by writing "fixes #1246" and GitHub will magically link the issue here and close it when this PR gets merged. Also, please fill up the template and provide a test plan as it helps to speed up the review process.

@yangshun yangshun changed the title docs: update api-pages.md docs: update api-pages.md to document about overriding default styles Mar 6, 2019
@yangshun yangshun merged commit 48f9521 into facebook:master Mar 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants