Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(codetabs): fix key warning #1284

Merged
merged 1 commit into from
Mar 18, 2019
Merged

Conversation

alexkrolick
Copy link
Contributor

@alexkrolick alexkrolick commented Mar 17, 2019

I thought the issue was a blocker for my project so I fixed it instead of waiting for the assignee, but it seems to be just a warning - sorry @oneuptim! Feel free to review/modify - I might have missed something!

@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Mar 17, 2019
@yangshun
Copy link
Contributor

yangshun commented Mar 17, 2019

Deploy preview for munseo-preview ready!

Built with commit ee3e5f8

https://deploy-preview-1284--munseo-preview.netlify.com

@docusaurus-bot
Copy link
Contributor

Deploy preview for docusaurus-preview ready!

Built with commit 4ca8040

https://deploy-preview-1284--docusaurus-preview.netlify.com

@docusaurus-bot
Copy link
Contributor

docusaurus-bot commented Mar 17, 2019

Deploy preview for docusaurus-preview ready!

Built with commit ee3e5f8

https://deploy-preview-1284--docusaurus-preview.netlify.com

Copy link
Contributor

@yangshun yangshun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! However in future, it would be better to check with @oneuptim before taking over a PR. @oneuptim feel free to find another PR to work on, you will get higher priority 😄

@yangshun yangshun merged commit f15ba1b into facebook:master Mar 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Warning: Each child in an array or iterator should have a unique "key" prop. when using Code Tabs
4 participants