-
-
Notifications
You must be signed in to change notification settings - Fork 8.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: handle TOC token as case insensitive #1288
fix: handle TOC token as case insensitive #1288
Conversation
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed. If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks! |
Deploy preview for munseo-preview ready! Built with commit 163622d |
Deploy preview for docusaurus-preview ready! Built with commit 163622d |
Well I see the generated netlify build itself has the issue, even without translation. Let me take a look into it. |
For sure @vikrantsinghthakur |
There were 2 builds generated for the PR with the same commit, munseo-preview and docusaurus-preview. |
Ignore the munseo-preview, thats the v2 build and lot of stuff is still wip on v2. Sent with GitHawk |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Instead of searching for the lower case version and the upper case version. We can do better with case insensitive search.
Regex allows this via “i” flag. Please refactor the code :)
6172abd
to
6a56578
Compare
Motivation
Fix #1234
Placeholder tokens going through crowdin get converted to lowercase. This PR tries to check for both uppercase and lowercase placeholder token to be replaced with table.
Have you read the Contributing Guidelines on pull requests?
YES
Test Plan
Use crowdin to generate translation and check if table of contents has been added correctly