Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: upgrade underscore.string to 3.3.5 #1404

Merged
merged 1 commit into from
Apr 28, 2019
Merged

Conversation

NishealJ
Copy link
Contributor

@NishealJ NishealJ commented Apr 27, 2019

Motivation

Fixes #1368. Debug, js-yaml and underscore.string had security vulnerabilities in the version which were using in our codebase. The mentioned dependencies are upgraded to their latest version to resolve security issues.

Have you read the Contributing Guidelines on pull requests?

Yes !

Test Plan

Related PRs

None

@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Apr 27, 2019
@docusaurus-bot
Copy link
Contributor

Deploy preview for docusaurus-2 ready!

Built with commit cd7b739

https://deploy-preview-1404--docusaurus-2.netlify.com

@docusaurus-bot
Copy link
Contributor

Deploy preview for docusaurus-preview ready!

Built with commit cd7b739

https://deploy-preview-1404--docusaurus-preview.netlify.com

@NishealJ
Copy link
Contributor Author

Hi @yangshun,
As a fix for #1368, Upgrading the notified dependency to their latest version must resolve the issue.
I've upgraded underscore.string to 3.3.5 PTAL ! , also regarding debug and js-yaml there are many version of these dependencies are listed in yarn.lock and are needed by other libraries.
How can i move ahead to upgrade debug and js-yaml?

Thanks :)

@yangshun yangshun changed the title Fixes #1368 : Resolving Security issues while installing Docusaurus fix: resolving Security issues while installing Docusaurus Apr 28, 2019
Copy link
Contributor

@yangshun yangshun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @NishealJ! In future you could add the "Fixes #1368" in the PR body too. Many thanks!

@yangshun yangshun changed the title fix: resolving Security issues while installing Docusaurus fix: upgrading underscore.string to 3.3.5 Apr 28, 2019
@yangshun yangshun changed the title fix: upgrading underscore.string to 3.3.5 fix: upgrade underscore.string to 3.3.5 Apr 28, 2019
@yangshun yangshun merged commit 9c27884 into facebook:master Apr 28, 2019
@NishealJ
Copy link
Contributor Author

Thanks @NishealJ! In future you could add the "Fixes #1368" in the PR body too. Many thanks!

yes sure @yangshun , That was quick thanks :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Installing docusaurus causes security vulnerabilities
4 participants