-
-
Notifications
You must be signed in to change notification settings - Fork 8.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(v2): easier plugin theme components swizzling #1436
Merged
Merged
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
386a03c
feat(v2): easier plugin theme components override
endiliey 87184c4
Merge branch 'master' of https://github.com/facebook/Docusaurus into …
endiliey cd87a11
add context
endiliey 93bb573
refactor again
endiliey fca5abc
rename eject -> swizzle
endiliey 43e668c
nits
endiliey File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,36 @@ | ||
/** | ||
* Copyright (c) 2017-present, Facebook, Inc. | ||
* | ||
* This source code is licensed under the MIT license found in the | ||
* LICENSE file in the root directory of this source tree. | ||
*/ | ||
|
||
const fs = require('fs-extra'); | ||
const chalk = require('chalk'); | ||
const path = require('path'); | ||
const importFresh = require('import-fresh'); | ||
|
||
module.exports = async function swizzle(siteDir, themeName, componentName) { | ||
const Plugin = importFresh(themeName); | ||
const context = {siteDir}; | ||
const PluginInstance = new Plugin(context); | ||
let fromPath = PluginInstance.getThemePath(); | ||
|
||
if (fromPath) { | ||
let toPath = path.resolve(siteDir, 'theme'); | ||
if (componentName) { | ||
fromPath = path.join(fromPath, componentName); | ||
toPath = path.join(toPath, componentName); | ||
} | ||
await fs.copy(fromPath, toPath); | ||
|
||
const relativeDir = path.relative(process.cwd(), toPath); | ||
const fromMsg = chalk.blue( | ||
componentName ? `${themeName}/${componentName}` : themeName, | ||
); | ||
const toMsg = chalk.cyan(relativeDir); | ||
console.log( | ||
`\n${chalk.green('Success!')} Copied ${fromMsg} to ${toMsg}.\n`, | ||
); | ||
} | ||
}; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could we shift these 3 chunks into
loadTheme
and rename existingloadTheme
toloadThemeInner
or something? Since we're already doing a lot of splitting this file up into its separate stages, I think we should continue keeping this file clean by shifting the very specific stuff into its own file.