refactor(v2): migrate core to Typescript ❄️🌀🐋 #1494
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview for docusaurus-2 ready! Built with commit 26f0125 |
|
Deploy preview for docusaurus-preview ready! Built with commit 26f0125 |
endiliey
commented
May 20, 2019
| "lint": "eslint --cache \"**/*.js\"", | ||
| "lerna": "lerna", | ||
| "test": "jest", | ||
| "tsc": "lerna run --parallel tsc --no-private" | ||
| "tsc": "lerna run tsc --no-private" |
There was a problem hiding this comment.
Cannot be run in parallel because there for example: docusaurus/core depends on docusaurus/utils.
| import fs from 'fs-extra'; | ||
| import importFresh from 'import-fresh'; | ||
| import path from 'path'; | ||
| import {generate} from '@docusaurus/utils'; |
There was a problem hiding this comment.
I don't deep dive into typing this part because we're going to change the plugin to use plain object instead of class instance
endiliey
changed the title
endiliey
changed the title
endiliey
changed the title
yangshun
approved these changes
May 20, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
This is the first step of converting @docusaurus/core to TypeScript. The PR is getting big already so I sent out this PR first. There are some parts of @docusaurus/core still using JS (very minimal though).
There should be almost no logic change. Just adding typing and at mostly refactoring/ moving folders around. I also added tests if needed.
Have you read the Contributing Guidelines on pull requests?
Yes
Test Plan
Development still working
Production still working
Test passes locally
Netlify
https://deploy-preview-1494--docusaurus-2.netlify.com/
Test passes in CI
Related PRs
#1490