-
-
Notifications
You must be signed in to change notification settings - Fork 8.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: add Render hosting guide #1615
Conversation
Deploy preview for docusaurus-2 ready! Built with commit f05e644 |
Deploy preview for docusaurus-preview ready! Built with commit f05e644 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for the late review. The PR looks ok but can we leave out updating the old versioned docs? The whole intention of versioning is to freeze old versions and new stuff should only go into new versions.
Makes sense and will submit an update shortly.
…On Thu, Jul 11, 2019 at 9:38 PM Yangshun Tay ***@***.***> wrote:
***@***.**** requested changes on this pull request.
Sorry for the late review. The PR looks ok but can we leave out updating
the old versioned docs? The whole intention of versioning is to freeze old
versions and new stuff should only go into new versions.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#1615?email_source=notifications&email_token=AAAOUANEX5XBSAVFHI5PD5TP7ADEZA5CNFSM4HZNGQA2YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOB6HWKCI#pullrequestreview-261055753>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAAOUAJT5QPTW3PBONXY33TP7ADEZANCNFSM4HZNGQAQ>
.
|
@yangshun PR updated. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
deploying for docusaurus 2 is slightly different.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
Motivation
Render is an official deployment option for create-react-app, gatsby, and hugo. This PR adds a guide for Docusaurus users who may want to host their site on Render.
Have you read the Contributing Guidelines on pull requests?
Yes.
Test Plan
yarn prettier && yarn lint
yarn test