Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add Render hosting guide #1615

Merged
merged 3 commits into from
Jul 12, 2019
Merged

docs: add Render hosting guide #1615

merged 3 commits into from
Jul 12, 2019

Conversation

anurag
Copy link
Contributor

@anurag anurag commented Jun 19, 2019

Motivation

Render is an official deployment option for create-react-app, gatsby, and hugo. This PR adds a guide for Docusaurus users who may want to host their site on Render.

Have you read the Contributing Guidelines on pull requests?

Yes.

Test Plan

  • yarn prettier && yarn lint
  • yarn test
  • Visual inspection of all doc versions.

@anurag anurag changed the title Add Render hosting guide doc: add Render hosting guide Jun 19, 2019
@docusaurus-bot
Copy link
Contributor

docusaurus-bot commented Jun 19, 2019

Deploy preview for docusaurus-2 ready!

Built with commit f05e644

https://deploy-preview-1615--docusaurus-2.netlify.com

@anurag anurag changed the title doc: add Render hosting guide docs: add Render hosting guide Jun 19, 2019
@docusaurus-bot
Copy link
Contributor

docusaurus-bot commented Jun 19, 2019

Deploy preview for docusaurus-preview ready!

Built with commit f05e644

https://deploy-preview-1615--docusaurus-preview.netlify.com

@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Jun 19, 2019
Copy link
Contributor

@yangshun yangshun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the late review. The PR looks ok but can we leave out updating the old versioned docs? The whole intention of versioning is to freeze old versions and new stuff should only go into new versions.

@anurag
Copy link
Contributor Author

anurag commented Jul 12, 2019 via email

@anurag
Copy link
Contributor Author

anurag commented Jul 12, 2019

Sorry for the late review. The PR looks ok but can we leave out updating the old versioned docs? The whole intention of versioning is to freeze old versions and new stuff should only go into new versions.

@yangshun PR updated.

Copy link
Contributor

@endiliey endiliey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

deploying for docusaurus 2 is slightly different.

website/docs/deployment.md Outdated Show resolved Hide resolved
Copy link
Contributor

@endiliey endiliey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Contributor

@yangshun yangshun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@yangshun yangshun merged commit ee2050d into facebook:master Jul 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants