refactor(v2): avoid synchronous/ blocking operation when possible #1957
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
endiliey
changed the title
endiliey
commented
Nov 11, 2019
| @@ -105,7 +104,7 @@ function normalizeSidebar(sidebars: SidebarRaw): Sidebar { | |||
| export default function loadSidebars(sidebarPath: string): Sidebar { | |||
| // We don't want sidebars to be cached because of hotreloading. | |||
| let allSidebars: SidebarRaw = {}; | |||
| if (sidebarPath && fs.existsSync(sidebarPath)) { | |||
| if (sidebarPath) { | |||
There was a problem hiding this comment.
Previously, if fake path is given, it is simply ignored
endiliey
added
pr: polish
|
Deploy preview for docusaurus-2 ready! Built with commit 3c8475b |
|
Deploy preview for docusaurus-preview ready! Built with commit 3c8475b |
yangshun
approved these changes
Nov 11, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Refactoring. Try to avoid fs sync operation since it blocks the whole nodejs thread loop.
Have you read the Contributing Guidelines on pull requests?
yes
Test Plan
(20s-21s)
- Development