fix(v2): remove invalid label attribute of footer links

[lex111]

Motivation

A continuation of #1974. This is relevant only for external links.

Have you read the Contributing Guidelines on pull requests?

Yes

Test Plan

Before:

<a class="footer__link-item" label="Stack Overflow" href="https://stackoverflow.com/questions/tagged/docusaurus" target="_blank" rel="noopener noreferrer">Stack Overflow</a>

After (without label):

<a class="footer__link-item" target="_blank" rel="noopener noreferrer" href="https://stackoverflow.com/questions/tagged/docusaurus">Stack Overflow</a>

[docusaurus-bot]

Deploy preview for docusaurus-2 ready!

Built with commit eda2bc7

https://deploy-preview-1980--docusaurus-2.netlify.com

[docusaurus-bot]

Deploy preview for docusaurus-preview ready!

Built with commit eda2bc7

https://deploy-preview-1980--docusaurus-preview.netlify.com

[yangshun]

It was intentional that I passed every prop through as attributes so users can add in more attributes that we don't support. That could have been a bad idea. Thoughts?

[endiliey]

Unlike #1974 this doesn't pass the rest of the props

[lex111]

But footer links cannot have additional attributes, unnecessarily add the rest of the props. https://v2.docusaurus.io/docs/docusaurus.config.js/#themeconfig
Only label and to.

[endiliey]

I'm thinking that maybe we should pass it so that it allow overriding even the target attribute ?

Like

 {
              label: 'Introduction',
              to: 'docs/introduction',
              target: '_blank'
            },

is possible

[lex111]

@endiliey done ✔️, yeah, now I see, all the more reason we need to keep consistency with navlinks.

[endiliey]

Now i wonder if we should put it right before label instead ? Otherwise the props cannot override rel and target for href

[lex111]

Yep, exactly, you are absolutely right, fixed!

[lex111]

Strange, Netlify fails, how to restart it?

[endiliey]

Strange, Netlify fails, how to restart it?

One way to restart is to push another commit 😢