Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(v2): add FB link to footer #1982

Merged
merged 1 commit into from
Nov 13, 2019
Merged

Conversation

lex111
Copy link
Contributor

@lex111 lex111 commented Nov 13, 2019

Motivation

The main Docusaurus site as well as the template should demonstrate the basic functionality, so I consider it rationale to add a recently added link field for the footer.

Have you read the Contributing Guidelines on pull requests?

Yes

Test Plan

See footer.

@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Nov 13, 2019
@docusaurus-bot
Copy link
Contributor

Deploy preview for docusaurus-2 ready!

Built with commit 00698b6

https://deploy-preview-1982--docusaurus-2.netlify.com

@docusaurus-bot
Copy link
Contributor

Deploy preview for docusaurus-preview ready!

Built with commit 00698b6

https://deploy-preview-1982--docusaurus-preview.netlify.com

@endiliey endiliey added pr: polish This PR adds a very minor behavior improvement that users will enjoy. pr: maintenance This PR does not produce any behavior differences to end users when upgrading. labels Nov 13, 2019
Copy link
Contributor

@endiliey endiliey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

might need to document Footer component sometimes in future ⭕️

@endiliey endiliey merged commit 0f30077 into facebook:master Nov 13, 2019
@wgao19
Copy link
Contributor

wgao19 commented Nov 14, 2019

#1640 document usage of footer

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA pr: maintenance This PR does not produce any behavior differences to end users when upgrading. pr: polish This PR adds a very minor behavior improvement that users will enjoy.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants