Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(v2): add documentation on versioning #2038

Merged
merged 3 commits into from
Nov 24, 2019
Merged

Conversation

endiliey
Copy link
Contributor

Motivation

Write documentation on versioning. Feel free to edit :)

Don't merge till #2030 is merged please, because versioning hasn't been released yet

Have you read the Contributing Guidelines on pull requests?

yes

Test Plan

versioning docs

Use netlify

@endiliey endiliey added the pr: documentation This PR works on the website or other text documents in the repo. label Nov 23, 2019
@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Nov 23, 2019
@docusaurus-bot
Copy link
Contributor

docusaurus-bot commented Nov 23, 2019

Deploy preview for docusaurus-2 ready!

Built with commit 04b8909

https://deploy-preview-2038--docusaurus-2.netlify.com

@docusaurus-bot
Copy link
Contributor

docusaurus-bot commented Nov 23, 2019

Deploy preview for docusaurus-preview ready!

Built with commit 04b8909

https://deploy-preview-2038--docusaurus-preview.netlify.com

Copy link
Contributor

@yangshun yangshun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding this! I proofread it and made some minor edits.

Some other recommended practices I can think of:

  • Don't use relative paths within the docs. Because when we cut a version the paths no longer work (the nesting level is different, among other reasons)
  • Assets can still be referenced in historical version of docs and should only be renamed/deleted if you are sure they are no longer referenced

@endiliey endiliey merged commit 160f6f5 into master Nov 24, 2019
@endiliey endiliey deleted the endi/versioning-doc branch November 24, 2019 11:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA pr: documentation This PR works on the website or other text documents in the repo.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants