Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(v2): add title attribute to anchor link #2066

Merged
merged 3 commits into from
Nov 29, 2019
Merged

Conversation

lex111
Copy link
Contributor

@lex111 lex111 commented Nov 28, 2019

Motivation

Add missing attr to link.

Have you read the Contributing Guidelines on pull requests?

Yes

Test Plan

image

@lex111 lex111 added the pr: polish This PR adds a very minor behavior improvement that users will enjoy. label Nov 28, 2019
@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Nov 28, 2019
@docusaurus-bot
Copy link
Contributor

Deploy preview for docusaurus-2 ready!

Built with commit 4dcaa4d

https://deploy-preview-2066--docusaurus-2.netlify.com

@docusaurus-bot
Copy link
Contributor

Deploy preview for docusaurus-preview ready!

Built with commit 4dcaa4d

https://deploy-preview-2066--docusaurus-preview.netlify.com

@docusaurus-bot
Copy link
Contributor

Deploy preview for docusaurus-2 ready!

Built with commit 47ea13b

https://deploy-preview-2066--docusaurus-2.netlify.com

@docusaurus-bot
Copy link
Contributor

Deploy preview for docusaurus-preview ready!

Built with commit 47ea13b

https://deploy-preview-2066--docusaurus-preview.netlify.com

@docusaurus-bot
Copy link
Contributor

Deploy preview for docusaurus-2 ready!

Built with commit 43cd394

https://deploy-preview-2066--docusaurus-2.netlify.com

@docusaurus-bot
Copy link
Contributor

Deploy preview for docusaurus-preview ready!

Built with commit 43cd394

https://deploy-preview-2066--docusaurus-preview.netlify.com

tabIndex="-1"
className="hash-link"
href={`#${id}`}
title="Direct link to heading">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we check in react-axe or something if this will cause duplicated title issue on a11y ?

Like every a title will be this Direct link to heading

Maybe

Suggested change
title="Direct link to heading">
title={`Direct link to heading with id` + id}>

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we check in react-axe or something if this will cause duplicated title issue on a11y ?

No, there will not be such an issue. I checked via the axe extension.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok we're good to merge this then

@yangshun yangshun merged commit dffa984 into master Nov 29, 2019
@lex111 lex111 deleted the lex111-patch-1 branch November 29, 2019 20:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA pr: polish This PR adds a very minor behavior improvement that users will enjoy.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants