Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(v2): windows compatibility regression #2086

Merged
merged 3 commits into from
Dec 5, 2019
Merged

fix(v2): windows compatibility regression #2086

merged 3 commits into from
Dec 5, 2019

Conversation

endiliey
Copy link
Contributor

@endiliey endiliey commented Dec 5, 2019

Motivation

This reverts #2039

Have you read the Contributing Guidelines on pull requests?

yes

Test Plan

Previously registry.js will be like this on Windows.

Error in babel
image

After

image

I've tested it on windows,
image

@endiliey endiliey added the pr: bug fix This PR fixes a bug in a past release. label Dec 5, 2019
@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Dec 5, 2019
@docusaurus-bot
Copy link
Contributor

docusaurus-bot commented Dec 5, 2019

Deploy preview for docusaurus-2 ready!

Built with commit 797bc73

https://deploy-preview-2086--docusaurus-2.netlify.com

@docusaurus-bot
Copy link
Contributor

docusaurus-bot commented Dec 5, 2019

Deploy preview for docusaurus-preview ready!

Built with commit 797bc73

https://deploy-preview-2086--docusaurus-preview.netlify.com

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA pr: bug fix This PR fixes a bug in a past release.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants