feat(v2): auto switch theme depending on the system theme #2117
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lex111
commented
Dec 11, 2019
|
|
||
| var preferDarkQuery = '(prefers-color-scheme: dark)'; | ||
| var mql = window.matchMedia(preferDarkQuery); | ||
| var supportsColorSchemeQuery = mql.media === preferDarkQuery; |
There was a problem hiding this comment.
I removed this redundant check, slightly simplified the code 🙄
|
Deploy preview for docusaurus-2 ready! Built with commit f4e220b |
|
Deploy preview for docusaurus-preview ready! Built with commit f4e220b |
yangshun
approved these changes
Dec 12, 2019
| } | ||
|
|
||
| var darkQuery = window.matchMedia('(prefers-color-scheme: dark)'); | ||
| darkQuery.addListener(function(e) { |
There was a problem hiding this comment.
TIL about listening to a media query
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
We can change the theme on the website depending on the installed system theme in real time. That is, when a user changes the theme in their OS, it changes on the website (if at that moment a tab with the website is open!)
Important point - if the user has already selected a theme on website, we do not switch theme when system theme has been changed.
Have you read the Contributing Guidelines on pull requests?
Yes
Test Plan