Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(v2): update link to available prism themes #2218

Merged
merged 2 commits into from
Jan 15, 2020

Conversation

jsjoeio
Copy link
Contributor

@jsjoeio jsjoeio commented Jan 15, 2020

Motivation

When you click on the link to view the available Prism themes, it points to as section in the README that does not list the themes. Instead, you must look at the themes directory. This PR updates that link to point to the right place :)

Have you read the Contributing Guidelines on pull requests?

Yes

Test Plan

N/A (link change - no test needed?)

Related PRs

(If this PR adds or changes functionality, please take some time to update the docs at https://github.com/facebook/docusaurus, and link to your PR here.)

@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Jan 15, 2020
@jsjoeio jsjoeio changed the title fix: update link to available prism themes fix(v2): update link to available prism themes Jan 15, 2020
@docusaurus-bot
Copy link
Contributor

docusaurus-bot commented Jan 15, 2020

Deploy preview for docusaurus-2 ready!

Built with commit 4a1d2b4

https://deploy-preview-2218--docusaurus-2.netlify.com

Copy link
Contributor

@yangshun yangshun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! Could you also update docusaurus/website/docs/theme-classic.md? That's the master version of the docs.

@jsjoeio jsjoeio requested a review from wgao19 as a code owner January 15, 2020 16:58
Copy link
Contributor

@yangshun yangshun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much @jsjoeio!

@jsjoeio
Copy link
Contributor Author

jsjoeio commented Jan 15, 2020

@yangshun Done!

@yangshun yangshun changed the title fix(v2): update link to available prism themes misc(v2): update link to available prism themes Jan 15, 2020
@yangshun yangshun changed the title misc(v2): update link to available prism themes docs(v2): update link to available prism themes Jan 15, 2020
@yangshun yangshun merged commit 68035cc into facebook:master Jan 15, 2020
@jsjoeio jsjoeio deleted the patch-1 branch January 15, 2020 17:00
@lex111 lex111 added the pr: documentation This PR works on the website or other text documents in the repo. label Jan 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA pr: documentation This PR works on the website or other text documents in the repo.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants