fix(v2): make code blocks scrollable #2241
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview for docusaurus-2 ready! Built with commit 630ae6f |
|
@yangshun please review on this weekend. I wanted to resolve this issue as quickly as possible. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
My second attempt to disable wrapping on code blocks! 😄
Based on the
yangshun/code-blockbranch (I did not wait for an answer and decided to deal with this issue myself).See #2048, #2056 (current PR uses changes from these PRs) to understand the context.
And as a bonus this PR also resolves #2223.
Have you read the Contributing Guidelines on pull requests?
Yes
Test Plan
On the desktop there should be no UI changes, but in the case of mobiles, the code blocks should become scollable. Although if the file contains long lines of code, then the scroll will be on the desktop, of course.