Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(v2): collapsible categories in sidebar #2251

Merged
merged 2 commits into from
Jan 31, 2020

Conversation

lex111
Copy link
Contributor

@lex111 lex111 commented Jan 29, 2020

Motivation

From discord:

Hi there! First of all, thx for this amazing project!
I like the collapsible sidebar but the possibility to choose wish one have to be open by default could be a real plus.
Should I open a feature request? Or does it make sense?

I previously added the ability to expand all categories in the doc sidebar, as it was in D1 by default, but this was only documented in Migration from v1 to v2 guide, so new users (who did not use Docusaurus at all) did not know about this possibility. This PR documents this feature in the Sidebar page so that all users know about it

Have you read the Contributing Guidelines on pull requests?

Yes

Test Plan

See Sidebar page.

Related PRs

(If this PR adds or changes functionality, please take some time to update the docs at https://github.com/facebook/docusaurus, and link to your PR here.)

@lex111 lex111 requested a review from yangshun January 29, 2020 04:25
@lex111 lex111 requested a review from wgao19 as a code owner January 29, 2020 04:25
@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Jan 29, 2020
website/docs/sidebar.md Outdated Show resolved Hide resolved
@docusaurus-bot
Copy link
Contributor

docusaurus-bot commented Jan 29, 2020

Deploy preview for docusaurus-2 ready!

Built with commit f2737fa

https://deploy-preview-2251--docusaurus-2.netlify.com

@lex111 lex111 added the pr: documentation This PR works on the website or other text documents in the repo. label Jan 30, 2020
Copy link
Contributor

@yangshun yangshun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I made small tweaks :D

Feel free to backport to past versions then self-merge.

@lex111 lex111 merged commit e27c8d0 into facebook:master Jan 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA pr: documentation This PR works on the website or other text documents in the repo.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants