fix(v2): switch a toggle when system theme changed #2325
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview for docusaurus-2 ready! Built with commit 154c350 |
yangshun
reviewed
Feb 26, 2020
| @@ -61,6 +61,14 @@ const useTheme = () => { | |||
| } | |||
| }, [setTheme]); | |||
|
|
|||
| useEffect(() => { | |||
| window | |||
There was a problem hiding this comment.
I think we need to check for disableDarkMode here, otherwise this runs on sites which still disable dark mode.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Resolve #2295.
Have you read the Contributing Guidelines on pull requests?
Yes
Test Plan
Go to preview and in the settings of your OS change the system theme to the opposite (dark -> light and vice versa). Make sure the theme and the toggle state in navbar change appropriately on the preview website.
Related PRs
(If this PR adds or changes functionality, please take some time to update the docs at https://github.com/facebook/docusaurus, and link to your PR here.)