Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(v2): mention about disabling Jekyll when using GitHub pages #2340

Merged
merged 2 commits into from
Feb 28, 2020

Conversation

amilajack
Copy link
Contributor

@amilajack amilajack commented Feb 27, 2020

Motivation

Prevent users from experiencing 404's with pages that are named with underscores

Closes #2332

Have you read the Contributing Guidelines on pull requests?

Yes

Test Plan

N/A

@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Feb 27, 2020
@docusaurus-bot
Copy link
Contributor

docusaurus-bot commented Feb 27, 2020

Deploy preview for docusaurus-2 ready!

Built with commit 78a98fc

https://deploy-preview-2340--docusaurus-2.netlify.com

Copy link
Contributor

@yangshun yangshun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've changed it from a separate section to an admonition. Many thanks Amila!

@yangshun yangshun changed the title docs(v2): add docs for disabling jekyll when using gh pages docs(v2): mention about disabling Jekyll when using GitHub pages Feb 28, 2020
@yangshun yangshun added the pr: documentation This PR works on the website or other text documents in the repo. label Feb 28, 2020
@yangshun yangshun merged commit 15e6763 into facebook:master Feb 28, 2020
@amilajack amilajack deleted the add-jekyll-disable-docs branch February 28, 2020 02:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA pr: documentation This PR works on the website or other text documents in the repo.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug (v2) html files with underscore prefix returning 404
4 participants