Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(v2): fix getPathsToWatch() example syntax in lifecycle APIs #2357

Merged
merged 2 commits into from
Mar 5, 2020

Conversation

rlamana
Copy link
Contributor

@rlamana rlamana commented Mar 4, 2020

Fix getPathsToWatch() example syntax issue

Motivation

Fix issue in documentation.

Fix getPathsToWatch() example syntax issue
@rlamana rlamana requested a review from yangshun as a code owner March 4, 2020 16:06
@facebook-github-bot
Copy link
Contributor

Hi @rlamana!

Thank you for your pull request and welcome to our community.We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file.

In order for us to review and merge your code, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@docusaurus-bot
Copy link
Contributor

docusaurus-bot commented Mar 4, 2020

Deploy preview for docusaurus-2 ready!

Built with commit d730ed5

https://deploy-preview-2357--docusaurus-2.netlify.com

@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Mar 4, 2020
@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@yangshun yangshun changed the title Fix getPathsToWatch() example syntax issue in lifecycle-apis.md docs(v2): fix getPathsToWatch() example syntax issue in lifecycle APIs Mar 5, 2020
@rlamana rlamana requested a review from wgao19 as a code owner March 5, 2020 01:22
@yangshun yangshun changed the title docs(v2): fix getPathsToWatch() example syntax issue in lifecycle APIs docs(v2): fix getPathsToWatch() example syntax in lifecycle APIs Mar 5, 2020
Copy link
Contributor

@yangshun yangshun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Many thanks!

@yangshun yangshun merged commit 4aee06e into facebook:master Mar 5, 2020
@yangshun yangshun added documentation The issue is related to the documentation of Docusaurus pr: documentation This PR works on the website or other text documents in the repo. and removed documentation The issue is related to the documentation of Docusaurus labels Mar 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA pr: documentation This PR works on the website or other text documents in the repo.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants